[jira] [Updated] (FOP-2875) [PATCH] basic-link to a file or an embedded file breaks if filename contains a parenthesis

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (FOP-2875) [PATCH] basic-link to a file or an embedded file breaks if filename contains a parenthesis

simon steiner (Jira)

     [ https://issues.apache.org/jira/browse/FOP-2875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eric Lim updated FOP-2875:
--------------------------
    Description:
The following FO snippet
{code:java}
<fo:basic-link external-destination="embedded-file:some(paren.pdf">The link to some file</fo:basic-link>{code}
produces the following PDF snippet
{code:java}
<<
/S /JavaScript
/JS (this.exportDataObject({cName:"some(paren.pdf", nLaunch:2});)
>>{code}
This PDF action is broken because the parenthesis are not escaped.

The correct output should be
{code:java}
<<
/S /JavaScript
/JS (this.exportDataObject\({cName:"some\(paren.pdf", nLaunch:2}\);)
>>{code}
 

  was:
The FO snippet

{{<fo:basic-link external-destination="embedded-[file:some(paren.pdf|file://some.pdf/]">The link to some file}}
{{ </fo:basic-link>}}

produces the following PDF snippet

{{<<}}
{{ /S /JavaScript}}
{{/JS (this.exportDataObject(\{cName:"some(paren.pdf", nLaunch:2});)}}
{{ >>}}

 

This action is broken because the parenthesis are not escaped.  

The correct output should be

{{<<}}
{{/S /JavaScript}}
{{/JS (this.exportDataObject\(\{cName:"some\(paren.pdf", nLaunch:2}\);)}}
{{ >>}}

 


> [PATCH]  basic-link to a file or an embedded file breaks if filename contains a parenthesis
> -------------------------------------------------------------------------------------------
>
>                 Key: FOP-2875
>                 URL: https://issues.apache.org/jira/browse/FOP-2875
>             Project: FOP
>          Issue Type: Bug
>          Components: renderer/pdf
>            Reporter: Eric Lim
>            Priority: Minor
>         Attachments: paren2.patch, test-case.fo
>
>
> The following FO snippet
> {code:java}
> <fo:basic-link external-destination="embedded-file:some(paren.pdf">The link to some file</fo:basic-link>{code}
> produces the following PDF snippet
> {code:java}
> <<
> /S /JavaScript
> /JS (this.exportDataObject({cName:"some(paren.pdf", nLaunch:2});)
> >>{code}
> This PDF action is broken because the parenthesis are not escaped.
> The correct output should be
> {code:java}
> <<
> /S /JavaScript
> /JS (this.exportDataObject\({cName:"some\(paren.pdf", nLaunch:2}\);)
> >>{code}
>  



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)