[jira] [Commented] (FOP-2536) [PATCH] Varying table border thickness in PDF output

Previous Topic Next Topic
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view

[jira] [Commented] (FOP-2536) [PATCH] Varying table border thickness in PDF output

JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/FOP-2536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15980952#comment-15980952 ]

ASF GitHub Bot commented on FOP-2536:

GitHub user segadora opened a pull request:


    Fixes problem with various border thickness

    More info on:

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Casalogic/fop patch/border

Alternatively you can review and apply these changes as the patch at:


To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4
commit e45f14e94ddb3209e570d95b40e392ee9175bcf9
Author: asf-sync-process <asf-sync-process@unknown>
Date:   2016-01-15T09:46:40Z

    Add tag
    git-svn-id: https://svn.apache.org/repos/asf/xmlgraphics/fop/tags/fop-2_1@1724753 13f79535-47bb-0310-9956-ffa450edef68

commit 063c888933a42a102619a74f9bb8e5c3b85ec5b5
Author: Christoffer Nielsen <[hidden email]>
Date:   2017-04-24T09:57:28Z

    Add border patch

commit c5429cc16fe5042c461d659550a1aa55c79e4651
Author: Christoffer Nielsen <[hidden email]>
Date:   2017-04-24T09:57:49Z

    Disable config option
    Disabled due that it only can be set in java (so it seems)


> [PATCH] Varying table border thickness in PDF output
> ----------------------------------------------------
>                 Key: FOP-2536
>                 URL: https://issues.apache.org/jira/browse/FOP-2536
>             Project: FOP
>          Issue Type: Improvement
>          Components: renderer/pdf
>            Reporter: Martin Leitner
>         Attachments: fop-2434-alternative.patch, patch-FOP-2434.diff, Polygon.java, tableBorders.fo, tableBorders_fop_2.0.pdf, tableBorders_fop_2.1_AdobeReader_11.png, tableBorders_fop_2.1.pdf, tableBorders_patched.pdf
> As already pointed out in a comment to the original issue, this is a problem with the PDF viewers. FOP generates the borders correctly. The viewers render border segments correctly when they are rectangles, but they make mistakes when the segments are more general polygons. In my patch, I am splitting the polygons into rectangles, covering as much of the polygon as possible, write the rectangles to the PDF, then write the remaining triangles.

This message was sent by Atlassian JIRA