Quantcast

[jira] [Commented] (FOP-2536) [PATCH] Varying table border thickness in PDF output

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[jira] [Commented] (FOP-2536) [PATCH] Varying table border thickness in PDF output

JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/FOP-2536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15958655#comment-15958655 ]

Chris Bowditch commented on FOP-2536:
-------------------------------------

Thanks [~matthias8283] Since you're a committer now I'm wondering why you have't committed this patch yet? Although I note there are no unit tests which should be added before doing so. I also find it odd that the name of the patch file is 2434, which its attached to 2536???

> [PATCH] Varying table border thickness in PDF output
> ----------------------------------------------------
>
>                 Key: FOP-2536
>                 URL: https://issues.apache.org/jira/browse/FOP-2536
>             Project: FOP
>          Issue Type: Improvement
>          Components: renderer/pdf
>            Reporter: Martin Leitner
>         Attachments: fop-2434-alternative.patch, patch-FOP-2434.diff, Polygon.java, tableBorders.fo, tableBorders_fop_2.0.pdf, tableBorders_fop_2.1_AdobeReader_11.png, tableBorders_fop_2.1.pdf, tableBorders_patched.pdf
>
>
> As already pointed out in a comment to the original issue, this is a problem with the PDF viewers. FOP generates the borders correctly. The viewers render border segments correctly when they are rectangles, but they make mistakes when the segments are more general polygons. In my patch, I am splitting the polygons into rectangles, covering as much of the polygon as possible, write the rectangles to the PDF, then write the remaining triangles.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
Loading...