[jira] [Commented] (FOP-2514) [PATCH] Empty hyphenation-character leads to "String index out of range: 0"

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (FOP-2514) [PATCH] Empty hyphenation-character leads to "String index out of range: 0"

Andreas Joseph Krogh (Jira)

    [ https://issues.apache.org/jira/browse/FOP-2514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16802885#comment-16802885 ]

Chris Bowditch commented on FOP-2514:
-------------------------------------

I've confirmed the fix works. However, I don't like the fact a lot of the code in CharacterProperty has been copied into the new class OptionalCharacterProperty. I'd prefer it if OptionalCharacterProperty extended CharacterProperty to reduce code duplication

Ideally the patch should include a unit test as well, but I can overlook that if you can fix the inheritance of OptionalCharacterProperty

> [PATCH] Empty hyphenation-character leads to "String index out of range: 0"
> ---------------------------------------------------------------------------
>
>                 Key: FOP-2514
>                 URL: https://issues.apache.org/jira/browse/FOP-2514
>             Project: FOP
>          Issue Type: Bug
>    Affects Versions: 2.0
>            Reporter: Bj√∂rn Kautler
>            Assignee: Chris Bowditch
>            Priority: Major
>         Attachments: hyphen.fo, issue-2514.patch
>
>
> If you set hyphenation-character to the empty value, then you get the error message "String index out of range: 0".
> If there is no hyphenation-character set, there should simply nothing be used.
> This is useful in cases where you want hyphenation but no hyphenation character like in program listings or similar



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)