Re: cvs commit: xml-fop/src/java/org/apache/fop/layoutmgr StaticContentLayoutManager.java LineLayoutManager.java AbstractLayoutManager.java TextLayoutManager.java LayoutManagerMapping.java ContentLayoutManager.java LeaderLayoutManager.java LayoutManager.j

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: cvs commit: xml-fop/src/java/org/apache/fop/layoutmgr StaticContentLayoutManager.java LineLayoutManager.java AbstractLayoutManager.java TextLayoutManager.java LayoutManagerMapping.java ContentLayoutManager.java LeaderLayoutManager.java LayoutManager.j

Luca Furini
Thanks for your optimization work, Glen.

Just a note: the method addALetterSpaceTo() is defined in the interface
InlineLevelLayoutManager and is still used.

It is called by LineLM.collectInlineKnuthElements(), if the last element
returned by a child LM and the first returned by the next child LM are
both boxes.

So, the CharacterLM and LeaderLM (extending LeafNodeLM, that implements
InlineLevelLM) should really implement it.

For example, if we have
  <fo:block>a <fo:character character="w"/>ord</fo:block>
we must tell the CharacterLM that the "w" is followed by a letter space,
as it is not a whole word.

Regards
    Luca



Reply | Threaded
Open this post in threaded view
|

Re: cvs commit: xml-fop/src/java/org/apache/fop/layoutmgr StaticContentLayoutManager.java LineLayoutManager.java AbstractLayoutManager.java TextLayoutManager.java LayoutManagerMapping.java ContentLayoutManager.java LeaderLayoutManager.java LayoutManager.j

GlenMazza
Luca,

Are you sure here?  We had two versions of addALetterSpaceTo() -- the
version in ILLM which takes a List (I didn't touch that one), and a old (?)
version from AbstractLayoutManager that takes a KnuthElement.  It is that
latter version that I removed--it wasn't being called anywhere--not the
former.

Glen

----- Original Message -----
From: "Luca Furini" <[hidden email]>
To: <[hidden email]>
Sent: Friday, June 10, 2005 2:19 PM
Subject: Re: cvs commit: xml-fop/src/java/org/apache/fop/layoutmgr
StaticContentLayoutManager.java LineLayoutManager.java
AbstractLayoutManager.java TextLayoutManager.java LayoutManagerMapping.java
ContentLayoutManager.java LeaderLayoutManager.java LayoutManager.java
CharacterLayoutManager.java BlockLayoutManager.java FlowLayoutManager.java


> Thanks for your optimization work, Glen.
>
> Just a note: the method addALetterSpaceTo() is defined in the interface
> InlineLevelLayoutManager and is still used.
>
> It is called by LineLM.collectInlineKnuthElements(), if the last element
> returned by a child LM and the first returned by the next child LM are
> both boxes.
>
> So, the CharacterLM and LeaderLM (extending LeafNodeLM, that implements
> InlineLevelLM) should really implement it.
>
> For example, if we have
>   <fo:block>a <fo:character character="w"/>ord</fo:block>
> we must tell the CharacterLM that the "w" is followed by a letter space,
> as it is not a whole word.
>
> Regards
>     Luca
>
>
>

Reply | Threaded
Open this post in threaded view
|

Re: cvs commit: xml-fop/src/java/org/apache/fop/layoutmgr StaticContentLayoutmanager.java LineLayoutManager.java AbstractLayoutManager.java TextLayoutManager.java LayoutManagerMapping.java ContentLayoutManager.java LeaderLayoutManager.java LayoutManager.j

Luca Furini-2
In reply to this post by Luca Furini
Glen Mazza wrote:

> Are you sure here?  We had two versions of addALetterSpaceTo() --
> the version in ILLM which takes a List (I didn't touch that one),
> and a old (?) version from AbstractLayoutManager that takes a
> KnuthElement.  It is that latter version that I removed--it
> wasn't being called anywhere--not the former.

Oops, sorry, you are completely right.

So, it seems that the new version of addALetterSpaceTo(), the one taking a
List, has not replaced all the occurences of the old one: I'm going to fix
this as soon as possible.

Regards
     Luca

Reply | Threaded
Open this post in threaded view
|

Re: cvs commit: xml-fop/src/java/org/apache/fop/layoutmgr StaticContentLayoutmanager.java LineLayoutManager.java AbstractLayoutManager.java TextLayoutManager.java LayoutManagerMapping.java ContentLayoutManager.java LeaderLayoutManager.java LayoutManager.j

GlenMazza
Thanks...with your IQ and my vacuum cleaner (and liposuction device, for
particularily hard-to-reach areas) we're gonna get layout looking really
*sleek*... ^u^

Glen


Luca Furini wrote:

> Glen Mazza wrote:
>
>> Are you sure here?  We had two versions of addALetterSpaceTo() --
>> the version in ILLM which takes a List (I didn't touch that one),
>> and a old (?) version from AbstractLayoutManager that takes a
>> KnuthElement.  It is that latter version that I removed--it wasn't
>> being called anywhere--not the former.
>
>
> Oops, sorry, you are completely right.
>
> So, it seems that the new version of addALetterSpaceTo(), the one
> taking a List, has not replaced all the occurences of the old one: I'm
> going to fix this as soon as possible.
>
> Regards
>     Luca
>
>