Evaluating test cases for different config settings

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Evaluating test cases for different config settings

Jan Tosovsky
Dear All,

I've tried adding a new test case for 'Varying table border thickness in PDF
output' patch:
https://issues.apache.org/jira/browse/FOP-2536

The patch is only effective in conjuction with 'overpaint-table-borders'
settings enabled:
userAgent.getRendererOptions().put("overpaint-table-borders", Boolean.TRUE);

(for my testing purposes I hardcoded it directly instead of retrieving it
dynamically)

But when this settings is enabled, some standard layout cases fail:
    [junit] Layout test (table-header_in_list_bug.xml): Expected XPath
expression to evaluate to '4', but got '14' (XPath:
count(//pageViewport[@nr='1']//block[@prod-id='table']/block))
    [junit] Layout test (table-stepper_colspan_border-before.xml): Expected
XPath expression to evaluate to '3', but got '12' (XPath:
count(//pageViewport[1]//flow/block[2]/block))

Is there any possibility to run some test cases with the different settings?

Thanks,

Jan

Reply | Threaded
Open this post in threaded view
|

Re: Evaluating test cases for different config settings

Matthias Reischenbacher
Hi Jan,

I've checked the code a bit and the LayoutEngineTestCase class doesn't
seem to support custom renderer options defined by the test case XML
file. But it shouldn't be too hard to add this functionality. Have a
look at org.apache.fop.layoutengine.LayoutEngineTestCase.runTest.

Thanks for continuing the work on this ticket! I'll commit the changes
as soon as your test cases are ready.

Best regards,

Matthias


On 08.06.2018 17:26, Jan Tosovsky wrote:

> Dear All,
>
> I've tried adding a new test case for 'Varying table border thickness in PDF
> output' patch:
> https://issues.apache.org/jira/browse/FOP-2536
>
> The patch is only effective in conjuction with 'overpaint-table-borders'
> settings enabled:
> userAgent.getRendererOptions().put("overpaint-table-borders", Boolean.TRUE);
>
> (for my testing purposes I hardcoded it directly instead of retrieving it
> dynamically)
>
> But when this settings is enabled, some standard layout cases fail:
>     [junit] Layout test (table-header_in_list_bug.xml): Expected XPath
> expression to evaluate to '4', but got '14' (XPath:
> count(//pageViewport[@nr='1']//block[@prod-id='table']/block))
>     [junit] Layout test (table-stepper_colspan_border-before.xml): Expected
> XPath expression to evaluate to '3', but got '12' (XPath:
> count(//pageViewport[1]//flow/block[2]/block))
>
> Is there any possibility to run some test cases with the different settings?
>
> Thanks,
>
> Jan
>